Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: core-dev@hadoop.apache.org
Message-ID: <796195462.1225125164314.JavaMail.jira@brutus>
Date: Mon, 27 Oct 2008 09:32:44 -0700 (PDT)
From: "Owen O'Malley (JIRA)" <jira@apache.org>
To: core-dev@hadoop.apache.org
Subject: [jira] Commented: (HADOOP-4516) Counter formatting for the user
 logs should be pulled out of the public Counters API
In-Reply-To: <876950886.1224866984588.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-4516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12642955#action_12642955 ] 

Owen O'Malley commented on HADOOP-4516:
---------------------------------------

The escaped compact format is only used for the log files. If there is another use, then we can make it public. In the mean time it just makes the public interface bigger and more confusing for users. 

However, it goes deeper than that. In particular, embedding various output formats in the Counters -> Groups -> Counters classes isn't necessary or good. It is better to have the different encodings in different classes that use the standard apis. 

> Counter formatting for the user logs should be pulled out of the public Counters API
> ------------------------------------------------------------------------------------
>
>                 Key: HADOOP-4516
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4516
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>            Reporter: Owen O'Malley
>             Fix For: 0.20.0
>
>
> Currently the mapred.Counters class includes an obsolete format (makeCompactString) and a format that is only used by the user logs (makeEscapeCompactString). makeCompactString should be deprecated and later removed.The makeEscapeCompactString should be refactored to a non-public class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.