Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 75789 invoked from network); 27 Oct 2008 10:37:13 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 27 Oct 2008 10:37:13 -0000 Received: (qmail 95184 invoked by uid 500); 27 Oct 2008 10:37:10 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 95153 invoked by uid 500); 27 Oct 2008 10:37:09 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 95142 invoked by uid 99); 27 Oct 2008 10:37:09 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Oct 2008 03:37:09 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 27 Oct 2008 10:36:04 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 69C5A234C23A for ; Mon, 27 Oct 2008 03:36:44 -0700 (PDT) Message-ID: <368847814.1225103804432.JavaMail.jira@brutus> Date: Mon, 27 Oct 2008 03:36:44 -0700 (PDT) From: "Amareshwari Sriramadasu (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Commented: (HADOOP-4498) JobHistory does not escape literal jobName when used in a regex pattern In-Reply-To: <2011703571.1224715304181.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-4498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12642892#action_12642892 ] Amareshwari Sriramadasu commented on HADOOP-4498: ------------------------------------------------- I submitted the job with name : [[name] value], without the patch and the job was successful. I was able to parse the history of the jobs with complex names too, both from the web ui and history viewer. Also the Testcase: testComplexName passes without the patch, though the Testcase: testComplexNameWithRegex failed Can you tell us how to reproduce the issue? > JobHistory does not escape literal jobName when used in a regex pattern > ----------------------------------------------------------------------- > > Key: HADOOP-4498 > URL: https://issues.apache.org/jira/browse/HADOOP-4498 > Project: Hadoop Core > Issue Type: Bug > Components: mapred > Affects Versions: 0.19.0 > Reporter: Chris K Wensel > Priority: Blocker > Attachments: hadoop-4498-v2.patch, hadoop-4498.patch > > > JobHistory#getJobHistoryFileName throws a PatternSyntaxException if the jobName includes characters that could be regex metacharacters or metasequences and are subsequently considered malformed. > Trace: > Exception in thread "initJobs" java.util.regex.PatternSyntaxException: Unclosed character class near index 97 > .... > at java.util.regex.Pattern.error(Pattern.java:1713) > at java.util.regex.Pattern.clazz(Pattern.java:2254) > at java.util.regex.Pattern.clazz(Pattern.java:2210) > at java.util.regex.Pattern.sequence(Pattern.java:1818) > at java.util.regex.Pattern.expr(Pattern.java:1752) > at java.util.regex.Pattern.compile(Pattern.java:1460) > at java.util.regex.Pattern.(Pattern.java:1133) > at java.util.regex.Pattern.compile(Pattern.java:823) > at org.apache.hadoop.mapred.JobHistory$JobInfo.getJobHistoryFileName(JobHistory.java:632) > at org.apache.hadoop.mapred.JobHistory$JobInfo.finalizeRecovery(JobHistory.java:740) > at org.apache.hadoop.mapred.JobTracker.finalizeJob(JobTracker.java:1532) > at org.apache.hadoop.mapred.JobInProgress.garbageCollect(JobInProgress.java:2232) > at org.apache.hadoop.mapred.JobInProgress.terminateJob(JobInProgress.java:1938) > at org.apache.hadoop.mapred.JobInProgress.terminate(JobInProgress.java:1953) > at org.apache.hadoop.mapred.JobInProgress.fail(JobInProgress.java:2012) > at org.apache.hadoop.mapred.EagerTaskInitializationListener$JobInitThread.run(EagerTaskInitializationListener.java:62) > at java.lang.Thread.run(Thread.java:637) -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.