Return-Path: 
 <core-dev-return-52742-apmail-hadoop-core-dev-archive=hadoop.apache.org@hadoop.apache.org>
Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org
Received: (qmail 15560 invoked from network); 16 Oct 2008 15:58:40 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 16 Oct 2008 15:58:40 -0000
Received: (qmail 59952 invoked by uid 500); 16 Oct 2008 15:58:37 -0000
Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org
Received: (qmail 59908 invoked by uid 500); 16 Oct 2008 15:58:37 -0000
Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:core-dev-help@hadoop.apache.org>
List-Unsubscribe: <mailto:core-dev-unsubscribe@hadoop.apache.org>
List-Post: <mailto:core-dev@hadoop.apache.org>
List-Id: <core-dev.hadoop.apache.org>
Reply-To: core-dev@hadoop.apache.org
Delivered-To: mailing list core-dev@hadoop.apache.org
Received: (qmail 59884 invoked by uid 99); 16 Oct 2008 15:58:37 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Oct 2008 08:58:37 -0700
X-ASF-Spam-Status: No, hits=-2000.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140)
    by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 16 Oct 2008 15:57:37 +0000
Received: from brutus (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id 72468234C230
	for <core-dev@hadoop.apache.org>; Thu, 16 Oct 2008 08:57:44 -0700 (PDT)
Message-ID: <348984703.1224172664466.JavaMail.jira@brutus>
Date: Thu, 16 Oct 2008 08:57:44 -0700 (PDT)
From: "Hudson (JIRA)" <jira@apache.org>
To: core-dev@hadoop.apache.org
Subject: [jira] Commented: (HADOOP-4408) FsAction operations shouldn't
 create new Objects
In-Reply-To: <1767628033.1223948744205.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/HADOOP-4408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640194#action_12640194 ] 

Hudson commented on HADOOP-4408:
--------------------------------

Integrated in Hadoop-trunk #635 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/635/])
    . FsAction functions need not create new objects.


> FsAction operations shouldn't create new Objects
> ------------------------------------------------
>
>                 Key: HADOOP-4408
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4408
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.16.0
>            Reporter: Chris Douglas
>            Assignee: Chris Douglas
>            Priority: Minor
>             Fix For: 0.20.0
>
>         Attachments: 4408-0.patch
>
>
> FsAction::and and related operations use {{values()[<expr>]}}, referencing a member var {{INDEX}}. This creates a new array object and uses member indices identical to {{ordinal()}}. It should either keep a reference to {{values()}} and use {{ordinal()}} explicitly or observe semantics consistent with {{INDEX}}.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.