Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: core-dev@hadoop.apache.org
Message-ID: <2113721116.1223023604321.JavaMail.jira@brutus>
Date: Fri, 3 Oct 2008 01:46:44 -0700 (PDT)
From: "Amareshwari Sriramadasu (JIRA)" <jira@apache.org>
To: core-dev@hadoop.apache.org
Subject: [jira] Commented: (HADOOP-4122) Duplicate code in JobHistory
 TaskAttempt's can be collapsed into super class.
In-Reply-To: <1716321929.1220938904749.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12636575#action_12636575 ] 

Amareshwari Sriramadasu commented on HADOOP-4122:
-------------------------------------------------

The methods logFailed() and logKilled() in JobInfo can also be merged into one method, since they differ only in one value. 

All the classes and all the methods to log the Job and task information, in JobHistory, are exposed to public, which is not necessary. They should be package private. This jira can make them package private. 

Thoughts?


> Duplicate code in JobHistory TaskAttempt's can be collapsed into super class. 
> ------------------------------------------------------------------------------
>
>                 Key: HADOOP-4122
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4122
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>            Priority: Blocker
>             Fix For: 0.19.0
>
>
> There is a lot of common code for MapAttempt, ReduceAttempt. All the duplicate code can be moved to TaskAttempt class. The methods logFailed() and logKilled() methods differ only in one string. They can be collapased into a single method.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.