Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: core-dev@hadoop.apache.org
Message-ID: <2033039319.1223699924559.JavaMail.jira@brutus>
Date: Fri, 10 Oct 2008 21:38:44 -0700 (PDT)
From: "stack (JIRA)" <jira@apache.org>
To: core-dev@hadoop.apache.org
Subject: [jira] Commented: (HADOOP-3422) Ganglia counter metrics are all
 reported with the metric name "value", so the counter values can not be
 seen
In-Reply-To: <103653028.1211304955568.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-3422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638717#action_12638717 ] 

stack commented on HADOOP-3422:
-------------------------------

Good stuff Brian.

1).  Just by way of FYI, see MetricsUtil in same package for how to add logging.  Import two classes, then just inside your class opening, add something like:

{code}
  private static final Log LOG =
    LogFactory.getLog("org.apache.hadoop.util.GangliaContext");
{code}

In code, do something like this:  LOG.warn("Type is null"); ... and so on.

2). Let me write Jason and see what he was up to with the ThreadLocal.  I don't understand.  Its not keeping any state so why bother with it.
3). Doesn't your patch also address HADOOP-4137 whereas diff-20080520-1025.txt does not?


> Ganglia counter metrics are all reported with the metric name "value", so the counter values can not be seen
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3422
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3422
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 0.18.1
>            Reporter: Jason
>         Attachments: diff-20080520-1025.txt, ganglia-patch-3422-and-4137.patch, ganglia-patch-3422-and-4137.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The JobInProgress class reports all metrics with the name "value". The FileMetrics class puts all of the tags into the name when reporting the individual values, but the Ganglia Context does not put the tags into the name..
> This patch modifies the context to build names for the counter metrics out of the tag values. This enables the user to see the indivdual counter values with the ganglia web tool, on a per job basis

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.