Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: core-dev@hadoop.apache.org
Message-ID: <1730457643.1223616824297.JavaMail.jira@brutus>
Date: Thu, 9 Oct 2008 22:33:44 -0700 (PDT)
From: "Vinod K V (JIRA)" <jira@apache.org>
To: core-dev@hadoop.apache.org
Subject: [jira] Commented: (HADOOP-4287) [mapred] jobqueue_details.jsp shows
 negative count of running and waiting reduces with CapacityTaskScheduler.
In-Reply-To: <96460383.1222419944215.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-4287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638484#action_12638484 ] 

Vinod K V commented on HADOOP-4287:
-----------------------------------

The fix is fine. I have a few test-case related comments.
 - You only have a test for failing maps, you should also have a test for failing reduces.
 - You should test for positive counts not just once, but through out the life time of the job; so you need to check it in a loop till job completion. Otherwise test-case success/failure would just be a matter of timing.
 - I think you can rename the test-case to TestJobInProgess, because part of which is what we are really testing here.
 - Minor : You shouldn't catch and ignore any exception thrown by RunningJob.runJob(). If something abnormal happens, let the test-case fail.

> [mapred] jobqueue_details.jsp shows negative count of running and waiting reduces with CapacityTaskScheduler.
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-4287
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4287
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/capacity-sched
>            Reporter: Vinod K V
>            Assignee: Sreekanth Ramakrishnan
>            Priority: Blocker
>         Attachments: HADOOP-4287-1.patch, HADOOP-4287-2.patch
>
>
> This I observed while running a job that always fails because of reduce failures. Need to investigate this.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.