Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: core-dev@hadoop.apache.org
Message-ID: <1373023491.1224507586408.JavaMail.jira@brutus>
Date: Mon, 20 Oct 2008 05:59:46 -0700 (PDT)
From: "Johan Oskarsson (JIRA)" <jira@apache.org>
To: core-dev@hadoop.apache.org
Subject: [jira] Commented: (HADOOP-4431) Add versionning/tags to Chukwa
 Chunk
In-Reply-To: <2004481787.1224181785711.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-4431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641001#action_12641001 ] 

Johan Oskarsson commented on HADOOP-4431:
-----------------------------------------

The patch looks good but I'm going to be picky, there are a few places in the patch where the code style is a bit off. It's using tabs instead of two spaces for indentation and { in the wrong places etc. Please see: http://wiki.apache.org/hadoop/HowToContribute for more information.

Other then that it looks good. Could you please regenerate it and I'll commit it. Is the patch to marked as an incompatible change?

> Add versionning/tags to Chukwa Chunk
> ------------------------------------
>
>                 Key: HADOOP-4431
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4431
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/chukwa
>            Reporter: Jerome Boulon
>            Assignee: Jerome Boulon
>         Attachments: HADOOP-4431.patch
>
>
> add tags field
> add version number to chunkImpl (contribute by Eric Y.)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.