Return-Path: 
 <core-dev-return-52390-apmail-hadoop-core-dev-archive=hadoop.apache.org@hadoop.apache.org>
Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org
Received: (qmail 61021 invoked from network); 13 Oct 2008 22:56:07 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2)
  by minotaur.apache.org with SMTP; 13 Oct 2008 22:56:07 -0000
Received: (qmail 70767 invoked by uid 500); 13 Oct 2008 22:56:05 -0000
Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org
Received: (qmail 70742 invoked by uid 500); 13 Oct 2008 22:56:05 -0000
Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:core-dev-help@hadoop.apache.org>
List-Unsubscribe: <mailto:core-dev-unsubscribe@hadoop.apache.org>
List-Post: <mailto:core-dev@hadoop.apache.org>
List-Id: <core-dev.hadoop.apache.org>
Reply-To: core-dev@hadoop.apache.org
Delivered-To: mailing list core-dev@hadoop.apache.org
Received: (qmail 70731 invoked by uid 99); 13 Oct 2008 22:56:05 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Oct 2008 15:56:05 -0700
X-ASF-Spam-Status: No, hits=-2000.0 required=10.0
	tests=ALL_TRUSTED
X-Spam-Check-By: apache.org
Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Oct 2008 22:55:07 +0000
Received: from brutus (localhost [127.0.0.1])
	by brutus.apache.org (Postfix) with ESMTP id 47B81234C21C
	for <core-dev@hadoop.apache.org>; Mon, 13 Oct 2008 15:55:44 -0700 (PDT)
Message-ID: <1117574938.1223938544292.JavaMail.jira@brutus>
Date: Mon, 13 Oct 2008 15:55:44 -0700 (PDT)
From: "Konstantin Shvachko (JIRA)" <jira@apache.org>
To: core-dev@hadoop.apache.org
Subject: [jira] Commented: (HADOOP-4358) NPE from CreateEditsLog
In-Reply-To: <654127090.1223339144335.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/HADOOP-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639241#action_12639241 ] 

Konstantin Shvachko commented on HADOOP-4358:
---------------------------------------------

{{CreateEditsLog}} generates edits file. It should be able to work without name-node present. Unfortunately, {{INode.setAccessTime()}} calls a static method on {{FSNamesystem}}, which had not been instantiated at the time. 
I think the right thing to do here is to store aTime as-is, rather than up to an hour. {{getAccessTime()}} then should round aTime up to the latset hour and return it.
{code}
void setAccessTime(long aTime) {
  this.accessTime = aTime;
}
long getAccessTime() {
  return (this.accessTime / precision) * precision;
}
{code}


> NPE from CreateEditsLog
> -----------------------
>
>                 Key: HADOOP-4358
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4358
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs, test
>    Affects Versions: 0.19.0
>            Reporter: Chris Douglas
>            Priority: Blocker
>             Fix For: 0.19.0
>
>
> HADOOP-1869 added a call to setAccessTime(long) from the INode cstr, which relies on a non-null value from FSNamesystem::getFSNamesystem.
> {noformat}
> java.lang.NullPointerException
>         at org.apache.hadoop.hdfs.server.namenode.INode.setAccessTime(INode.java:301)
>         at org.apache.hadoop.hdfs.server.namenode.INode.<init>(INode.java:99)
>         at org.apache.hadoop.hdfs.server.namenode.INodeDirectory.<init>(INodeDirectory.java:45)
>         at org.apache.hadoop.hdfs.CreateEditsLog.addFiles(CreateEditsLog.java:68)
>         at org.apache.hadoop.hdfs.CreateEditsLog.main(CreateEditsLog.java:214)
> {noformat}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.