[ https://issues.apache.org/jira/browse/HADOOP-4228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638714#action_12638714 ] 

Hadoop QA commented on HADOOP-4228:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12391556/metricsLong1.patch
  against trunk revision 703609.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3442/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3442/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3442/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3442/console

This message is automatically generated.

> dfs datanode metrics, bytes_read, bytes_written overflows due to incorrect type used.
> -------------------------------------------------------------------------------------
>
>                 Key: HADOOP-4228
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4228
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 0.18.2, 0.19.0
>         Environment: Red Hat Enterprise Linux AS release 4 (Nahant Update 5), Java 1.6.
>            Reporter: Eric Yang
>            Assignee: Eric Yang
>            Priority: Blocker
>             Fix For: 0.18.2, 0.19.0
>
>         Attachments: HADOOP-4228-trunk.patch, HADOOP-4228.patch, metricsLong.patch, metricsLong1-br18.patch, metricsLong1.patch
>
>
> bytes_read, and bytes_written metrics are using int (MetricsTimeVaryingInt) as counter.  This type is too small to store the bytes_read and bytes_written metrics.  Recommend to change this to long (metricsLongValue).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.