hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-4358) NPE from CreateEditsLog
Date Wed, 15 Oct 2008 19:04:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-4358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12639932#action_12639932

Tsz Wo (Nicholas), SZE commented on HADOOP-4358:

Konstantin> This will be inconsistent with getAccessTime(). Or do you propose to "unround"
it back after getting access time.

Yes, I am proposing both getAccessTime() and setAccessTime(..) should use int.

When reading/writing access time to edits/images, precision could be passed as a parameter
and atime is written as a long.

Dhruba> Is it possible to come up with a solution that allows me to have different precisions
for two different clusters? 

What do you mean by this?  What operation you want to support?  I think we cannot compare
access times with different precisions in some cases.  Supposed atime1="Oct 15, 11:00am" and
atime2="Oct 15, 11:00am".  However, atime1 and atime2 have precisions 1 hour and 1 minute,
respectively.  Then, we cannot tell whether atime1 is < or == or > atime2.

Dhruba> Ideally, the precision should be a filesystem constant and can change only when
you format a HDFS filesystem. 

I think we could safely allow decreasing precision.  e.g. changing 1hour to 1day.  For increasing
precision, we should thrown an exception.

> NPE from CreateEditsLog
> -----------------------
>                 Key: HADOOP-4358
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4358
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs, test
>    Affects Versions: 0.19.0
>            Reporter: Chris Douglas
>            Priority: Blocker
>             Fix For: 0.19.0
> HADOOP-1869 added a call to setAccessTime(long) from the INode cstr, which relies on
a non-null value from FSNamesystem::getFSNamesystem.
> {noformat}
> java.lang.NullPointerException
>         at org.apache.hadoop.hdfs.server.namenode.INode.setAccessTime(INode.java:301)
>         at org.apache.hadoop.hdfs.server.namenode.INode.<init>(INode.java:99)
>         at org.apache.hadoop.hdfs.server.namenode.INodeDirectory.<init>(INodeDirectory.java:45)
>         at org.apache.hadoop.hdfs.CreateEditsLog.addFiles(CreateEditsLog.java:68)
>         at org.apache.hadoop.hdfs.CreateEditsLog.main(CreateEditsLog.java:214)
> {noformat}

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message