hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vinod K V (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-4420) JobTracker.killJob() doesn't check for the JobID being valid
Date Thu, 30 Oct 2008 10:33:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-4420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12643806#action_12643806
] 

Vinod K V commented on HADOOP-4420:
-----------------------------------

For Hadoop-0.20, we should think about ways of informing clients about the failures, instead
of just returning silently, as Hemanth pointed out [here|https://issues.apache.org/jira/browse/HADOOP-4419?focusedCommentId=12639889#action_12639889].
This needs API changes and so the approach in the current patch is fine for 0.19.

Some comments about this patch.
 - You don't have a null check for JobID in setJobPriority.
 - The update you made for Changes.txt is not getting applied cleanly. I think you can leave
that to be done by the committer of this patch. 
 

> JobTracker.killJob() doesn't check for the JobID being valid
> ------------------------------------------------------------
>
>                 Key: HADOOP-4420
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4420
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.19.0, 0.20.0
>            Reporter: Steve Loughran
>            Priority: Minor
>         Attachments: hadoop-4420.patch
>
>
> As with HADOOP-4419, JobTracker.killJob() assumes that the supplied JobID always matches
to a valid job.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message