hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Chris Douglas (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-3790) Add more unit tests to test appending to files in HDFS
Date Fri, 10 Oct 2008 00:50:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638458#action_12638458

Chris Douglas commented on HADOOP-3790:

The patch looks good. A few suggestions:
* Instead of local blocks, each of these should probably be separate tests. All can use the
same static MiniDFSCluster using TestSetup, as in TestDatamerge, TestReduceFetch, etc.
* In TC11, does it make sense to check the return value of fs.rename?
* Since it's essentially dead code in trunk, it might make more sense to make TC3 part of
HADOOP-4379 instead of enabling it once it can be expected to pass

> Add more unit tests to test appending to files in HDFS
> ------------------------------------------------------
>                 Key: HADOOP-3790
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3790
>             Project: Hadoop Core
>          Issue Type: Test
>          Components: test
>            Reporter: dhruba borthakur
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.19.0
>         Attachments: 3790_20081008.patch
> A new feature "appends to HDFS files" have been implemented in HADOOP-1700. There are
a set of unit tests in TestFileAppend.java and TestFileAppend2.java. But we would like to
have more unit tests.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message