hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom White (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-4187) Create a MapReduce-specific ReflectionUtils that handles JobConf and JobConfigurable
Date Wed, 22 Oct 2008 15:25:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-4187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641887#action_12641887
] 

Tom White commented on HADOOP-4187:
-----------------------------------

I think we should use Configuration#getClassByName instead of Class#forName.

bq. The current patch includes a test for this in util.TestReflectionUtils which I realize
may not be the ideal place. At some point, the tests will also be split between core, hdfs
and mapred. So perhaps this testcase should be added to mapred in a new class mapred.TestReflectionUtils.
This way it automatically gets deprecated along with the mapred package.

I don't think we normally deprecate tests, since they aren't part of the public API. So I
think what you've done is fine.  When JobConf is finally removed then the test won't compile
so it will be removed too. I hope that we remember to remove the code it tests too - perhaps
a comment in the code would help?

> Create a MapReduce-specific ReflectionUtils that handles JobConf and JobConfigurable
> ------------------------------------------------------------------------------------
>
>                 Key: HADOOP-4187
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4187
>             Project: Hadoop Core
>          Issue Type: Sub-task
>            Reporter: Tom White
>            Assignee: Sharad Agarwal
>         Attachments: 4187_v1.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message