hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-3422) Ganglia counter metrics are all reported with the metric name "value", so the counter values can not be seen
Date Fri, 10 Oct 2008 06:01:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12638491#action_12638491
] 

stack commented on HADOOP-3422:
-------------------------------

I took a look at the patch.  You have this in a few places '// TODO: Log this.'.   Why not
log the exception? 

You keep a ThreadLocal StringBuffer to save on construction cost?  Could you use a StringBuilder
instead of a StringBuffer?

Otherwise, this patch is great.  I tried it.  Ganglia graphs work with this in place.

> Ganglia counter metrics are all reported with the metric name "value", so the counter
values can not be seen
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3422
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3422
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: metrics
>    Affects Versions: 0.18.1
>            Reporter: Jason
>         Attachments: diff-20080520-1025.txt, ganglia-patch-3422-and-4137.patch, ganglia-patch-3422-and-4137.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The JobInProgress class reports all metrics with the name "value". The FileMetrics class
puts all of the tags into the name when reporting the individual values, but the Ganglia Context
does not put the tags into the name..
> This patch modifies the context to build names for the counter metrics out of the tag
values. This enables the user to see the indivdual counter values with the ganglia web tool,
on a per job basis

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message