hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Amar Kamat (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-4428) Job Priorities are not handled properly
Date Mon, 20 Oct 2008 09:00:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-4428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12640950#action_12640950
] 

Amar Kamat commented on HADOOP-4428:
------------------------------------

Few comments :
1) Plz make sure that there are no unnecessary diffs.
For example
1)
{code}
-  
-  private FakeJobInProgress submitJob(int state, int maps, int reduces, 
-      String queue, String user) throws IOException {
+
+  private FakeJobInProgress submitJob(int state, int maps, int reduces,
+      String queue, String user, JobPriority priority)
+      throws IOException {
{code}
Here _private FakeJobInProgress submitJob(int state, int maps, int reduces,_  should not be
in the diff (removed space).
2)
{code}
-  
+
{code}
is useless (removed space).
3) 
{code}
-    FakeJobInProgress job = new FakeJobInProgress(
-        new JobID("test", ++jobCounter), jobConf, taskTrackerManager, user);
+    FakeJobInProgress job =
+        new FakeJobInProgress(new JobID("test", ++jobCounter), jobConf,
+            taskTrackerManager, user);
{code}
is also unnecessarily added to the diff.
2) {{testJobRunStateChange()}} uses the old {{submitJob()}} api which I dont see fixed.
----
Just to clarify, jobs in the waiting queue can still be inited out of order when the capacity
is exceeded.

> Job Priorities are not handled properly 
> ----------------------------------------
>
>                 Key: HADOOP-4428
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4428
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: contrib/capacity-sched
>    Affects Versions: 0.19.0
>         Environment: Cluster:  106 TTs  MapCapacity=212, ReduceCapacity=212
> Single Queue=default, User Limit=25, Priorities = Yes.
> Using hadoop branch 0.19 revision=705159 
>            Reporter: Karam Singh
>            Assignee: Vinod K V
>            Priority: Blocker
>             Fix For: 0.19.0
>
>         Attachments: HADOOP-4428-20081017.1.txt, HADOOP-4428-20081020.txt
>
>
> Job Priorities are not handled properly 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message