Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: core-dev@hadoop.apache.org
Message-ID: <717466261.1222797584381.JavaMail.jira@brutus>
Date: Tue, 30 Sep 2008 10:59:44 -0700 (PDT)
From: "Doug Cutting (JIRA)" <jira@apache.org>
To: core-dev@hadoop.apache.org
Subject: [jira] Commented: (HADOOP-4044) Create symbolic links in HDFS
In-Reply-To: <132525105.1219991324428.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635796#action_12635796 ] 

Doug Cutting commented on HADOOP-4044:
--------------------------------------

This is looking good.  A few nits:
- let's call it just 'link' not 'symlink', okay?  If we ever implement generic hard links, we'd make those the qualified case.
- several implementations of getSymlink() still do not throw exceptions when isLink() is false.
- FSDataInputStream and FSDataOutputStream should not directly implement FSLinkable.  Rather, openImpl, createImpl and appendImpl should return FSDataInputStreamLink and FSDataOutputStreamLink, classes which wrap a stream and a link, then the public method can dereference this to return FSDataInputStream and FSDataOutputStream as before.
 - shouldn't all of the implementations of Impl methods be protected, not public?

Note: I am reviewing only the src/core sections of this patch, not the src/hdfs.


> Create symbolic links in HDFS
> -----------------------------
>
>                 Key: HADOOP-4044
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4044
>             Project: Hadoop Core
>          Issue Type: New Feature
>          Components: dfs
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>         Attachments: symLink1.patch, symLink1.patch, symLink4.patch, symLink5.patch, symLink6.patch, symLink8.patch
>
>
> HDFS should support symbolic links. A symbolic link is a special type of file that contains a reference to another file or directory in the form of an absolute or relative path and that affects pathname resolution. Programs which read or write to files named by a symbolic link will behave as if operating directly on the target file. However, archiving utilities can handle symbolic links specially and manipulate them directly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.