Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 68790 invoked from network); 4 Sep 2008 02:54:38 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 4 Sep 2008 02:54:38 -0000 Received: (qmail 40682 invoked by uid 500); 4 Sep 2008 02:54:33 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 40652 invoked by uid 500); 4 Sep 2008 02:54:33 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 40636 invoked by uid 99); 4 Sep 2008 02:54:33 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Sep 2008 19:54:33 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 04 Sep 2008 02:53:43 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 635B6234C1C8 for ; Wed, 3 Sep 2008 19:53:44 -0700 (PDT) Message-ID: <571837586.1220496824405.JavaMail.jira@brutus> Date: Wed, 3 Sep 2008 19:53:44 -0700 (PDT) From: "Konstantin Shvachko (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Commented: (HADOOP-4014) DFS upgrade fails on Windows In-Reply-To: <1443412745.1219646264545.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-4014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628236#action_12628236 ] Konstantin Shvachko commented on HADOOP-4014: --------------------------------------------- I'd rather introduce a static member {{OSType osType;}} and use it to verify in which order the arguments should be set in the command line. {{osType}} should replace {{osName}} with the latter becoming a local variable of {{getOSType()}}. You effectively do the same by comparing command name is "fsutil". Checking osType seems to be cleaner. "XpP" - is a good catch. Did you really try it on Vista? > DFS upgrade fails on Windows > ---------------------------- > > Key: HADOOP-4014 > URL: https://issues.apache.org/jira/browse/HADOOP-4014 > Project: Hadoop Core > Issue Type: Bug > Components: fs > Affects Versions: 0.18.0 > Environment: Windows XP, Windows 2003 Server > Reporter: NOMURA Yoshihide > Attachments: HADOOP-4014.patch > > > FileUtil.HardLink#createHardLink() didn't work on Windows, and DFS upgrade of Datanode fails. > The windows command 'fsutil' requires the arguments link name first as follows, > > fsutil hardlink create > But the current FileUtil passes the target first. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.