Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 29155 invoked from network); 3 Sep 2008 17:26:41 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 3 Sep 2008 17:26:41 -0000 Received: (qmail 26163 invoked by uid 500); 3 Sep 2008 17:26:34 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 25708 invoked by uid 500); 3 Sep 2008 17:26:33 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 25665 invoked by uid 99); 3 Sep 2008 17:26:33 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Sep 2008 10:26:33 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Sep 2008 17:25:43 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 822AA234C1C8 for ; Wed, 3 Sep 2008 10:25:44 -0700 (PDT) Message-ID: <249475015.1220462744531.JavaMail.jira@brutus> Date: Wed, 3 Sep 2008 10:25:44 -0700 (PDT) From: "Raghu Angadi (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Commented: (HADOOP-3943) NetworkTopology.pseudoSortByDistance does not need to be a synchronized method In-Reply-To: <26083534.1218586064342.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628064#action_12628064 ] Raghu Angadi commented on HADOOP-3943: -------------------------------------- That keeps it "as correct as before", which is fine. +1 > NetworkTopology.pseudoSortByDistance does not need to be a synchronized method > ------------------------------------------------------------------------------ > > Key: HADOOP-3943 > URL: https://issues.apache.org/jira/browse/HADOOP-3943 > Project: Hadoop Core > Issue Type: Improvement > Components: dfs > Reporter: Hairong Kuang > Assignee: Hairong Kuang > Fix For: 0.19.0 > > Attachments: sortDistance.patch > > > When all requests to namenode are read, most handlers block on NetworkTopology object lock when sorting replicas. Removing this necessary lock would reduce the contention in namenode and therefore improve its throughput. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.