Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: core-dev@hadoop.apache.org
Message-ID: <160159278.1220742584243.JavaMail.jira@brutus>
Date: Sat, 6 Sep 2008 16:09:44 -0700 (PDT)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: core-dev@hadoop.apache.org
Subject: [jira] Commented: (HADOOP-3963) libhdfs should never exit on its
 own but rather return errors to the calling application
In-Reply-To: <1799744464.1218838184211.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12628924#action_12628924 ] 

Hadoop QA commented on HADOOP-3963:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12389619/patch1.txt
  against trunk revision 692700.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3199/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3199/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3199/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3199/console

This message is automatically generated.

> libhdfs should never exit on its own but rather return errors to the calling application
> ----------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3963
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3963
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: libhdfs
>            Reporter: Pete Wyckoff
>            Assignee: Pete Wyckoff
>            Priority: Minor
>             Fix For: 0.19.0
>
>         Attachments: patch0.txt, patch1.txt
>
>
> A a library, libhdfs would be better to return errors rather than directly exiting. This way the calling application can determine what to do on error. And it is more unix library like to handle errors this way.
> Some applications like fuse-dfs need to handle the exit themselves after emitting an appropriate error message to its log.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.