Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: core-dev@hadoop.apache.org
Message-ID: <1253516415.1222464464418.JavaMail.jira@brutus>
Date: Fri, 26 Sep 2008 14:27:44 -0700 (PDT)
From: "Konstantin Shvachko (JIRA)" <jira@apache.org>
To: core-dev@hadoop.apache.org
Subject: [jira] Commented: (HADOOP-3614) TestLeaseRecovery fails when run
 with assertions enabled.
In-Reply-To: <1328784672.1214002665251.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635029#action_12635029 ] 

Konstantin Shvachko commented on HADOOP-3614:
---------------------------------------------

I think assert is right here. It means that {{findBlockFile()}} method should find a file containing the block by its block id no matter what its generation stamp is, and therefore findBlockFile should always be called with the generation stamp == WILDCARD_STAMP.
What is incorrect here is the api. {{findBlockFile(long blockID)}} should take block ID as a parameter and then the assert can be removed.
A comment stating exactly what the method does would be extremely helpful.

> TestLeaseRecovery fails when run with assertions enabled.
> ---------------------------------------------------------
>
>                 Key: HADOOP-3614
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3614
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>             Fix For: 0.19.0
>
>
> I used -ea jvm options to run the test, and it fails in FSDataset.findBlockFile(Block) on 
> {code}
> assert b.generationStamp == GenerationStamp.WILDCARD_STAMP;
> {code}
> Without asserts on the test passes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.