Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: core-dev@hadoop.apache.org
Message-ID: <1045392948.1221610904437.JavaMail.jira@brutus>
Date: Tue, 16 Sep 2008 17:21:44 -0700 (PDT)
From: "Konstantin Shvachko (JIRA)" <jira@apache.org>
To: core-dev@hadoop.apache.org
Subject: [jira] Commented: (HADOOP-3623) LeaseManager needs refactoring.
In-Reply-To: <977081009.1214262585227.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631608#action_12631608 ] 

Konstantin Shvachko commented on HADOOP-3623:
---------------------------------------------

{{syncBlock()}} does not need {{namenode}} parameter.
+1 The rest looks neat.

> LeaseManager needs refactoring.
> -------------------------------
>
>                 Key: HADOOP-3623
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3623
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.19.0
>
>         Attachments: 3623_20080915.patch
>
>
> LeaseManager is a name-node class, which contains (after HADOOP-3310) static members and methods serving data-node code.
> I think we should keep the code related to different components of hdfs separatly, especially in view of the upcoming changes in hdfs packaging HADOOP-2884.
> The separation may be achieved by introducing a new class DatanodeLeaseManager and then moving all related methods into the new class.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.