hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-4044) Create symbolic links in HDFS
Date Tue, 30 Sep 2008 17:59:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635796#action_12635796

Doug Cutting commented on HADOOP-4044:

This is looking good.  A few nits:
- let's call it just 'link' not 'symlink', okay?  If we ever implement generic hard links,
we'd make those the qualified case.
- several implementations of getSymlink() still do not throw exceptions when isLink() is false.
- FSDataInputStream and FSDataOutputStream should not directly implement FSLinkable.  Rather,
openImpl, createImpl and appendImpl should return FSDataInputStreamLink and FSDataOutputStreamLink,
classes which wrap a stream and a link, then the public method can dereference this to return
FSDataInputStream and FSDataOutputStream as before.
 - shouldn't all of the implementations of Impl methods be protected, not public?

Note: I am reviewing only the src/core sections of this patch, not the src/hdfs.

> Create symbolic links in HDFS
> -----------------------------
>                 Key: HADOOP-4044
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4044
>             Project: Hadoop Core
>          Issue Type: New Feature
>          Components: dfs
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>         Attachments: symLink1.patch, symLink1.patch, symLink4.patch, symLink5.patch,
symLink6.patch, symLink8.patch
> HDFS should support symbolic links. A symbolic link is a special type of file that contains
a reference to another file or directory in the form of an absolute or relative path and that
affects pathname resolution. Programs which read or write to files named by a symbolic link
will behave as if operating directly on the target file. However, archiving utilities can
handle symbolic links specially and manipulate them directly.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message