hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alejandro Abdelnur (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-4293) Remove WritableJobConf
Date Mon, 29 Sep 2008 04:20:47 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-4293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635283#action_12635283
] 

Alejandro Abdelnur commented on HADOOP-4293:
--------------------------------------------

For HADOOP-3702 we needed to serialize a {{JobConf}} into a {{String}}.

There were 3 possible alternatives considered:

# *Make {{Configuration}} or {{JobConf}} implement {{Writable}}* The problem with this option
is that {{Configuration}} already as a {{write(OutputStream)}} method (that serializes to
XML) and making it to implement {{Writable}} was creating compiler conflicts when used with
a {{DataOutptuStream}} instance. 

# *Make a {{Serialization}} implementation for {{Configuration}} (then used by its subclasses)*
There was some opposition to do this.

# *Make a subclass of {{JobConf}} that implements {{Writable}}* This was the proposed alternative.


I didn't want to do Option #1 not to break backwards compatibility (quite a few places in
core and contribs).

I preferred Option #2 but I did not have an objection to Option #3.

If people feel that Option #2 is more adequate I could make that change (one of the patches
was doing this approach)


> Remove WritableJobConf 
> -----------------------
>
>                 Key: HADOOP-4293
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4293
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: mapred
>    Affects Versions: 0.19.0
>            Reporter: Owen O'Malley
>            Assignee: Owen O'Malley
>             Fix For: 0.19.0
>
>         Attachments: 4293-2.patch, 4293.patch
>
>
> The new class WritableJobConf doesn't add value over just making JobConf Writable, and
I propose that we remove it before it is released.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message