hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-4006) Cleanup HDFS FSConstants
Date Fri, 19 Sep 2008 22:50:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-4006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632856#action_12632856
] 

Konstantin Shvachko commented on HADOOP-4006:
---------------------------------------------

- I like {{DataTransferProtocol}}. I was thinking about creating such a class and placing
common data transfer methods in it. Say, serialization of block locations, opening sockets,
verifying replies can belong to this protocol. Right now we duplicate code in different places
rather than reusing it.
More, this protocol is used not only for client-to-data-node communication but also between
data-nodes themselves.
- Although it is not an ipc protocol it is still versioned, so I'm +1 to derive DataTransferProtocol
from VersionedProtocol.

> Cleanup HDFS FSConstants
> ------------------------
>
>                 Key: HADOOP-4006
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4006
>             Project: Hadoop Core
>          Issue Type: Sub-task
>          Components: dfs
>            Reporter: Sanjay Radia
>             Fix For: 0.19.0
>
>         Attachments: refactorConstants2.patch, refactorConstants3.patch, refactorConstants4.patch
>
>
>  * Remove RPC Codes - they are unused
>  * Move the data node streaming constants into its own interfaces/class
>  * Remove the extends FSConstants

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message