hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-4210) Findbugs warnings are printed related to equals implementation of several classes
Date Tue, 30 Sep 2008 12:56:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-4210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635737#action_12635737

Hadoop QA commented on HADOOP-4210:

-1 overall.  Here are the results of testing the latest attachment 
  against trunk revision 700322.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 Eclipse classpath. The patch retains Eclipse classpath integrity.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3402/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3402/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3402/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/3402/console

This message is automatically generated.

> Findbugs warnings are printed related to equals implementation of several classes
> ---------------------------------------------------------------------------------
>                 Key: HADOOP-4210
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4210
>             Project: Hadoop Core
>          Issue Type: Bug
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>             Fix For: 0.20.0
>         Attachments: HADOOP-4210.patch, HADOOP-4210.patch, HADOOP4210.patch
> During compilation - findbugs generates several warnings that indicates bugs in the implementation
of equals method. One of the example of this report is:
> Bug type EQ_GETCLASS_AND_CLASS_CONSTANT (click for details)
> In class org.apache.hadoop.mapred.ID
> In method org.apache.hadoop.mapred.ID.equals(Object)
> At ID.java:[line 66]
> Value doesn't work for subtypes
> This class has an equals method that will be broken if it is inherited by subclasses.
It compares a class literal with the class of the argument (e.g., in class Foo it might check
if Foo.class == o.getClass()). It is better to check if this.getClass() == o.getClass().

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message