hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yuri Pradkin (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-4226) LineReader::readLine cleanup
Date Mon, 29 Sep 2008 15:27:47 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-4226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12635415#action_12635415
] 

Yuri Pradkin commented on HADOOP-4226:
--------------------------------------

bq. old patches are not deleted, as they orphan the discussion about them.
Sorry about that: started deleting inconsequential patches and got carried away.

bq. If this could include a short summary of the strategy employed and a few more comments,
it would be more readily understandable the next time a change is proposed.
I'm not a java programmer, so I could use some advice here on where would such summary go:
javadoc comments (/**...**/) or the policy is to keep them short and the longer comments should
go somewhere else?

bq. CR and LF should be final, as in the previous patch
If people were to re-use this class with different newline separators, they might find it
useful to be able to change CR and LF.  Maybe they should not be static and be public, so
they can simply be assigned to?

> LineReader::readLine cleanup
> ----------------------------
>
>                 Key: HADOOP-4226
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4226
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>    Affects Versions: 0.19.0
>            Reporter: Yuri Pradkin
>            Assignee: Yuri Pradkin
>            Priority: Minor
>         Attachments: HADOOP-4226.patch
>
>
> I've been looking at HADOOP-4010 and realized that readLine is pretty convoluted.  I
changed the implementation which made it hopefully a little easier to read/validate/understand.
 
> I've had some problems testing it locally, so I'll submit it for Hudson to test.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message