hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (HADOOP-4198) DFSClient should do lease recovery using data transfer port.
Date Thu, 18 Sep 2008 18:00:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-4198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12632069#action_12632069
] 

szetszwo edited comment on HADOOP-4198 at 9/18/08 11:00 AM:
--------------------------------------------------------------------------

{noformat}
     [exec] -1 overall.  

     [exec]     +1 @author.  The patch does not contain any @author tags.

     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified
tests.
     [exec]                         Please justify why no tests are needed for this patch.

     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.

     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.

     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
{noformat}

No new tests added since there are already a lot of tests for lease recovery and file creation.

      was (Author: szetszwo):
    {noformat}
     [exec] -1 overall.  

     [exec]     +1 @author.  The patch does not contain any @author tags.

     [exec]     -1 tests included.  The patch doesn't appear to include any new or modified
tests.
     [exec]                         Please justify why no tests are needed for this patch.

     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.

     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.

     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
{noformat}

No new tests added since there are already a lot test for lease recovery and file creation.
  
> DFSClient should do lease recovery using data transfer port.
> ------------------------------------------------------------
>
>                 Key: HADOOP-4198
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4198
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>    Affects Versions: 0.18.0
>            Reporter: Konstantin Shvachko
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Blocker
>             Fix For: 0.18.2
>
>         Attachments: 4198_20080917.patch, 4198_20080917b.patch
>
>
> HADOOP-3283 introduced {{dfs.datanode.ipc.address}} which defines where the data-node
rpc server runs.
> The rpc server on a data-node is used only for lease recovery (HADOOP-3310).
> Lease recovery can be initialized by a name-node or by a client.
> The problem was reported if lease recovery is initialized by a client running on an untrusted
host.
> The port that the http server runs on is closed for the outside use and therefore lease
recovery fails.
> Production level security model assumes that data-nodes are run on trusted nodes and
therefore it is safe to have ports open for inter data-node communication.
> HDFS clients can run on arbitrary nodes and according to the security model can access
only the ports that are externally open.
> We propose to use the standard data node port for lease recovery, which means that lease
recovery will use {{DataXceiver}} and data transfer protocol rather than {{ClientDatanodeProtocol}}.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message