hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pete Wyckoff (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-3787) Add serialization for Thrift
Date Mon, 15 Sep 2008 21:11:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631138#action_12631138
] 

Pete Wyckoff commented on HADOOP-3787:
--------------------------------------

-1 on this part as you don't clear the object before deserializing into it, which doesn't
do a clear. Since there's no clear for a thrift object now, you would have to return a new
object everytime, so the code should always ignore what's passed in.  Given HADOOP-1230, this
won't currently work because line 75 of SequenceFileRecordReader:

>    boolean remaining = (in.next(key) != null);

Throws out the return value of SequenceFile.next which is the result of
deserialize(obj).



{code}
  public T deserialize(T t) throws IOException {
    T object = (t == null ? newInstance() : t);
    try {
      object.read(protocol);
    } catch (TException e) {
      throw new IOException(e.toString());
    }
    return object;
  }
{code}



> Add serialization for Thrift
> ----------------------------
>
>                 Key: HADOOP-3787
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3787
>             Project: Hadoop Core
>          Issue Type: Wish
>          Components: examples, mapred
>            Reporter: Tom White
>         Attachments: hadoop-3787.patch, libthrift.jar
>
>
> Thrift (http://incubator.apache.org/thrift/) is cross-language serialization and RPC
framework. This issue is to write a ThriftSerialization to support using Thrift types in MapReduce
programs, including an example program. This should probably go into contrib.
> (There is a prototype implementation in https://issues.apache.org/jira/secure/attachment/12370464/hadoop-serializer-v2.tar.gz)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message