hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joydeep Sen Sarma (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-4138) [Hive] refactor the SerDe library
Date Mon, 15 Sep 2008 23:11:46 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12631180#action_12631180

Joydeep Sen Sarma commented on HADOOP-4138:

i thought we pretty much ruled out objectinspectors being different for different rows in
the same task - no?

and for the reflection stuff  there is real caching going on.  Would it be fair to say then
that the factory code could be better refactored (removed even):
- reflectionoi does caching (the constructor could check an inbuilt static cache) and the
thrift stuff would inherit (ie. no need for factory)
- for other standard* oi's - no caching is required - just straight constructors would be
good enough.

the factory code is unnecessarily hard to understand IMHO and does not encapsulate things
very well (considering that class specific logic must be put in the factory - which is a strange
pattern indeed). A programmer looking to add serde's/objectinspector is likely to look at
the factory class (which the normal expectations from a factory class) and be reasonbly plussed.

i am not saying this is a blocker - just that complexity can be reduced and code be made more
developer friendly.

> [Hive] refactor the SerDe library
> ---------------------------------
>                 Key: HADOOP-4138
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4138
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/hive
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>             Fix For: 0.19.0
>         Attachments: HADOOP-4138-1.txt, HADOOP-4138-2.txt, HADOOP-4138-3.txt, HADOOP-4138-4.txt,
> Hive uses the library from src/contrib/hive/serde to do serialization/deserialization.
> We want to do a refactoring of the library to:
> 1. Split Serializer and Deserializer interface
> 2. Split Serializer/Deserializer and ObjectInspector interface
> 3. Change hive/metaserver and hive/ql to use the new SerDe framework

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message