hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hairong Kuang (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-3663) Allow relative paths to be created inside archives.
Date Fri, 12 Sep 2008 21:25:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630685#action_12630685
] 

Hairong Kuang commented on HADOOP-3663:
---------------------------------------

The code looks good. I have a few comments:
1. In usage, relative src should be src because absolution paths are still supported.
2. Will the code be cleaner if the archive method takes relative paths as the second parameter?
The structure of the parent directory does not need to write to srcWriter. Only relative paths
need to be passed to mappers too.
3. Will it be more efficient if the relPathToRoot works on Strings?

> Allow relative paths to be created inside archives.
> ---------------------------------------------------
>
>                 Key: HADOOP-3663
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3663
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: tools/harchive
>    Affects Versions: 0.18.0
>            Reporter: Mahadev konar
>            Assignee: Mahadev konar
>             Fix For: 0.19.0
>
>         Attachments: HADOOP-3663.patch, HADOOP-3663.patch
>
>
> Archives currently stores the full path from the input sources -- since it allows multiple
sources and regular expressions as inputs. So the created archives have the full path of the
input sources. This is un intuitive and a user hassle. We should get rid of it and allow users
to say that the created archive should be relative to some absolute path and throw an excpetion
if the input does not confirm to the relative absolute path.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message