Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: core-dev@hadoop.apache.org
Message-ID: <578672413.1218238244270.JavaMail.jira@brutus>
Date: Fri, 8 Aug 2008 16:30:44 -0700 (PDT)
From: "Hairong Kuang (JIRA)" <jira@apache.org>
To: core-dev@hadoop.apache.org
Subject: [jira] Commented: (HADOOP-3497) File globbing with a PathFilter is
 too restrictive
In-Reply-To: <1762646057.1212669825315.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HADOOP-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621094#action_12621094 ] 

Hairong Kuang commented on HADOOP-3497:
---------------------------------------

Tom, nice change! Two comments:
1. I think the checking if paths are accepted by the filter or not (lines 932-936 in Filesystem.java) should be performed no matter last component of the path pattern has a pattern or not. Your patch does the checking only when last component does not have a pattern.
2. This patch probably should be marked as an incompatible change. The trunk implements a wrong semantics.

> File globbing with a PathFilter is too restrictive
> --------------------------------------------------
>
>                 Key: HADOOP-3497
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3497
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.17.0
>            Reporter: Tom White
>         Attachments: hadoop-3497-test.patch, hadoop-3497.patch
>
>
> Consider the file hierarchy
> {noformat}
> /a
> /a/b
> {noformat}
> Calling the globStatus method on FileSystem with a path of {noformat}/*/*{noformat} and a PathFilter that only accepts {{/a/b}} returns no matches. It should return a single match: {{/a/b}}.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.