Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 87378 invoked from network); 26 Aug 2008 01:54:06 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 26 Aug 2008 01:54:06 -0000 Received: (qmail 25690 invoked by uid 500); 26 Aug 2008 01:54:03 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 25646 invoked by uid 500); 26 Aug 2008 01:54:03 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 25635 invoked by uid 99); 26 Aug 2008 01:54:03 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 25 Aug 2008 18:54:03 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Aug 2008 01:53:14 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 642FA234C1B5 for ; Mon, 25 Aug 2008 18:53:44 -0700 (PDT) Message-ID: <1350976712.1219715624409.JavaMail.jira@brutus> Date: Mon, 25 Aug 2008 18:53:44 -0700 (PDT) From: "Chris Douglas (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Updated: (HADOOP-3506) Occasional NPE in Jets3tFileSystemStore In-Reply-To: <187346839.1212707687227.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-3506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Douglas updated HADOOP-3506: ---------------------------------- Resolution: Fixed Fix Version/s: 0.19.0 Hadoop Flags: [Reviewed] Status: Resolved (was: Patch Available) +1 Looks good I just committed this. Thanks, Tom > Occasional NPE in Jets3tFileSystemStore > --------------------------------------- > > Key: HADOOP-3506 > URL: https://issues.apache.org/jira/browse/HADOOP-3506 > Project: Hadoop Core > Issue Type: Bug > Components: fs/s3 > Affects Versions: 0.17.0 > Reporter: Robert > Assignee: Tom White > Fix For: 0.19.0 > > Attachments: hadoop-3506.patch > > > In extraordinary circumstances (eg. S3 outages), calling S3FileSystem functions will throw NullPointerExceptions when trying to read from the filesystem. I've traced this down to calls to Jets3tFileSystemStore.get(). > Both get() functions catch an S3ServiceException, and check its error code using a string comparison. However, the underlying libs3t library will sometimes produce an exception with a null error code string. This results in an NPE that propagates all the way to the S3FileSystem, and to the caller. > To fix this, Jets3tFileSystemStore lines 196 and 212 should be changed from: > bq. if (e.getS3ErrorCode().equals("NoSuchKey")) { > to: > bq. if ("NoSuchKey".equals(e.getS3ErrorCode())) { -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.