hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hairong Kuang (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-3497) File globbing with a PathFilter is too restrictive
Date Fri, 08 Aug 2008 23:30:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12621094#action_12621094
] 

Hairong Kuang commented on HADOOP-3497:
---------------------------------------

Tom, nice change! Two comments:
1. I think the checking if paths are accepted by the filter or not (lines 932-936 in Filesystem.java)
should be performed no matter last component of the path pattern has a pattern or not. Your
patch does the checking only when last component does not have a pattern.
2. This patch probably should be marked as an incompatible change. The trunk implements a
wrong semantics.

> File globbing with a PathFilter is too restrictive
> --------------------------------------------------
>
>                 Key: HADOOP-3497
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3497
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 0.17.0
>            Reporter: Tom White
>         Attachments: hadoop-3497-test.patch, hadoop-3497.patch
>
>
> Consider the file hierarchy
> {noformat}
> /a
> /a/b
> {noformat}
> Calling the globStatus method on FileSystem with a path of {noformat}/*/*{noformat} and
a PathFilter that only accepts {{/a/b}} returns no matches. It should return a single match:
{{/a/b}}.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message