hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Raghu Angadi (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-3935) Extract classes from DataNode.java
Date Wed, 13 Aug 2008 18:48:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622318#action_12622318
] 

Raghu Angadi commented on HADOOP-3935:
--------------------------------------


looks good. Looks like it the case, but I will mention anyway : since we can not verify the
blocks of code transferred, please make sure there are as few changes as possible a part from
cut-n-paste.

Regd  DataXceiverServer, it is so integrated with DataXceiver that it could just be a static
class 'DataXceiver.Server' or 'DataXceiver.Acceptor'. But this is not required.

On the similar lines, DFSClient.java is also ripe for such a split. In a seperate jira, we
should add hdfs/client directory and and split DFSClient there.

> Extract classes from DataNode.java
> ----------------------------------
>
>                 Key: HADOOP-3935
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3935
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>            Reporter: Johan Oskarsson
>            Assignee: Johan Oskarsson
>            Priority: Trivial
>         Attachments: HADOOP-3935.patch, HADOOP-3935.patch
>
>
> DataNode.java is becoming hard to navigate with over 3000 lines of code. I suggest moving
some of the classes out into their own files in the same package. This will also make it easier
to see how the classes depend on each other and to see what code belongs where.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message