hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Johan Oskarsson (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HADOOP-3935) Extract classes from DataNode.java
Date Thu, 14 Aug 2008 12:55:44 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Johan Oskarsson updated HADOOP-3935:
------------------------------------

    Attachment: HADOOP-3935.patch
                patch.sh

Thanks for the feedback, I have renamed the Throttler and changed the visibility. I also moved
the test (see patch.sh). I left the other two points for another time, there's still some
refactoring work that could be done but I feel they're out of the scope for this ticket.

I assume the hudson patch processor can't handle file rename scripts, so unless someone has
any objections I'll commit these changes soon. There is one test that fails but it is unrelated
to these changes, see HADOOP-3950.

> Extract classes from DataNode.java
> ----------------------------------
>
>                 Key: HADOOP-3935
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3935
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>            Reporter: Johan Oskarsson
>            Assignee: Johan Oskarsson
>            Priority: Trivial
>         Attachments: HADOOP-3935.patch, HADOOP-3935.patch, HADOOP-3935.patch, patch.sh
>
>
> DataNode.java is becoming hard to navigate with over 3000 lines of code. I suggest moving
some of the classes out into their own files in the same package. This will also make it easier
to see how the classes depend on each other and to see what code belongs where.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message