hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HADOOP-3854) org.apache.hadoop.http.HttpServer should support user configurable filter
Date Sat, 09 Aug 2008 01:00:48 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Tsz Wo (Nicholas), SZE updated HADOOP-3854:
-------------------------------------------

    Status: Open  (was: Patch Available)

bq. Sorry, one more idea.  The constant PUBLIC_FACING_URLS is fragile.  If someone adds another
servlet that's intended to be public-facing, subject to filters, then it will not automatically
be added to this.  I propose limiting this constant to non-servlet stuff like "*.html" and
"*.jsp", then modify HttpServer#addServlet() to add a boolean isFiltered parameter, deprecating
the existing signature.  Then each added servlet must declare whether it's filtered or not,
which should reduce surprises.

No problem.  I think this is a very good idea.

bq. Also, I don't see the point of passing the filter configs to the ctor.  Shouldn't we just
always create the filters automatically from the config?  We need to add a Configuration parameter
to HttpServer for this, but that seems better than a FilterConfiguration[] parameter, since
'FilterConfiguration.getFilterConfigurations(conf)' won't be duplicated so much, and it would
permit further configuration of HttpServer in the future.

Done.

> org.apache.hadoop.http.HttpServer should support user configurable filter
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-3854
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3854
>             Project: Hadoop Core
>          Issue Type: New Feature
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: 3854_20080729.patch, 3854_20080730.patch, 3854_20080805.patch, 3854_20080806.patch,
3854_20080807.patch, 3854_20080808.patch, LoggingFilter.java, LoggingFilterConfiguration.java,
SampleInitializer.java
>
>
> Filters provide universal functions such as authentication, logging and auditing, etc.
 HttpServer should support configurable filters, so that individual site administrators could
possibly configure filters for their web site.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message