hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-3935) Extract classes from DataNode.java
Date Thu, 14 Aug 2008 18:49:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622638#action_12622638
] 

Tsz Wo (Nicholas), SZE commented on HADOOP-3935:
------------------------------------------------

Hi Johan, for a committing a patch, we need to follow the guidelines in http://wiki.apache.org/hadoop/HowToContribute
.  In particular, we should use Submit Patch link like other contributors, and then wait for
a "+1" from another committer before committing, as stated in the "Contributing your work"
session.

> Extract classes from DataNode.java
> ----------------------------------
>
>                 Key: HADOOP-3935
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3935
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>            Reporter: Johan Oskarsson
>            Assignee: Johan Oskarsson
>            Priority: Trivial
>             Fix For: 0.19.0
>
>         Attachments: HADOOP-3935.patch, HADOOP-3935.patch, HADOOP-3935.patch, patch.sh
>
>
> DataNode.java is becoming hard to navigate with over 3000 lines of code. I suggest moving
some of the classes out into their own files in the same package. This will also make it easier
to see how the classes depend on each other and to see what code belongs where.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message