hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Johan Oskarsson (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-3935) Extract classes from DataNode.java
Date Fri, 15 Aug 2008 08:57:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622844#action_12622844
] 

Johan Oskarsson commented on HADOOP-3935:
-----------------------------------------

Hi. Yes, perhaps I got a bit trigger happy. Although I did get a +1 from another committer
and I assumed that the "submit patch to hudson" wouldn't be able to pick up on the renaming
of the test using patch.sh and would fail. Perhaps there is a better way to do this which
I am not aware of?

Glad to get feedback though, need to properly get the hang of the process

> Extract classes from DataNode.java
> ----------------------------------
>
>                 Key: HADOOP-3935
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3935
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>            Reporter: Johan Oskarsson
>            Assignee: Johan Oskarsson
>            Priority: Trivial
>             Fix For: 0.19.0
>
>         Attachments: HADOOP-3935.patch, HADOOP-3935.patch, HADOOP-3935.patch, patch.sh
>
>
> DataNode.java is becoming hard to navigate with over 3000 lines of code. I suggest moving
some of the classes out into their own files in the same package. This will also make it easier
to see how the classes depend on each other and to see what code belongs where.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message