hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ben Slusky (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HADOOP-3549) meaningful errno values in libhdfs
Date Thu, 14 Aug 2008 14:59:45 GMT

     [ https://issues.apache.org/jira/browse/HADOOP-3549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Ben Slusky updated HADOOP-3549:

    Status: Patch Available  (was: Open)

How about this patch, which eliminates that ugly macro altogether?

> meaningful errno values in libhdfs
> ----------------------------------
>                 Key: HADOOP-3549
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3549
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: libhdfs
>    Affects Versions: 0.17.1
>         Environment: any POSIX
>            Reporter: Ben Slusky
>            Assignee: Ben Slusky
>         Attachments: libhdfs-01-exception-handling.patch, libhdfs-02-meaningful-errno.patch,
libhdfs-03-combined.patch, libhdfs-04.patch
> A comment near the top of hdfs.h says that "All APIs set errno to meaningful values."
Unfortunately this is a big fat lie -- bigger and fatter still now that we have permissions
in HDFS. If Hadoop throws an AccessControlException, then libhdfs sets errno to EINTERNAL,
even though this is not an "internal" error in any sense of the word.
> With the attached patches, allow libhdfs to derive a useful errno value when an exception
is thrown. I've implemented handling for AccessControlException and a few others whose semantics
seem obvious.
> Tangential question: The signatures for invokeMethod() and constructNewObjectOfClass()
in hdfsJniHelper.h disagreed with their comments. Was the "exc" argument of those functions
removed in the past, or never implemented? I (re)instated it in my patch.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message