hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Johan Oskarsson (JIRA)" <j...@apache.org>
Subject [jira] Issue Comment Edited: (HADOOP-3935) Extract classes from DataNode.java
Date Wed, 13 Aug 2008 15:54:44 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12622260#action_12622260
] 

johanoskarsson edited comment on HADOOP-3935 at 8/13/08 8:53 AM:
------------------------------------------------------------------

* I have moved PacketResponder to BlockReceiver.
* Changed the classes to use the DataNode logger.
* Changed public method comments to javadocs
* The reason for renaming DataXceiveServer to DataXceiverServer is simply because I assumed
it was a typo since the other class is called DataXceiver.
* I left Throttler more or less as is since it is being used by multiple classes and a test
outside of the package. As mentioned it is fairly generic and could possibly be used by other
classes.

      was (Author: johanoskarsson):
    * I have moved PacketResponder to BlockReceiver.
* Changed the classes to use the DataNode logger.
* Changed public method comments to javadocs
* The reason for renaming DataXceiveServer to DataXceiveServer is simply because I assumed
it was a typo since the other class is called DataXceiver.
* I left Throttler more or less as is since it is being used by multiple classes and a test
outside of the package. As mentioned it is fairly generic and could possibly be used by other
classes.
  
> Extract classes from DataNode.java
> ----------------------------------
>
>                 Key: HADOOP-3935
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3935
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: dfs
>            Reporter: Johan Oskarsson
>            Assignee: Johan Oskarsson
>            Priority: Trivial
>         Attachments: HADOOP-3935.patch, HADOOP-3935.patch
>
>
> DataNode.java is becoming hard to navigate with over 3000 lines of code. I suggest moving
some of the classes out into their own files in the same package. This will also make it easier
to see how the classes depend on each other and to see what code belongs where.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message