Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 37772 invoked from network); 25 Jul 2008 04:32:28 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 25 Jul 2008 04:32:28 -0000 Received: (qmail 51266 invoked by uid 500); 25 Jul 2008 04:32:22 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 51248 invoked by uid 500); 25 Jul 2008 04:32:22 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 51237 invoked by uid 99); 25 Jul 2008 04:32:22 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 24 Jul 2008 21:32:22 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 25 Jul 2008 04:31:36 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id B1B95234C184 for ; Thu, 24 Jul 2008 21:31:31 -0700 (PDT) Message-ID: <138623726.1216960291726.JavaMail.jira@brutus> Date: Thu, 24 Jul 2008 21:31:31 -0700 (PDT) From: "Hadoop QA (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Commented: (HADOOP-3661) Normalize fuse-dfs handling of moving things to trash wrt the way hadoop dfs does it (only when non posix trash flag is enabled in compile) In-Reply-To: <1174115917.1214606624996.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-3661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616761#action_12616761 ] Hadoop QA commented on HADOOP-3661: ----------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12386672/patch2.txt against trunk revision 679601. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 8 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2945/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2945/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2945/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2945/console This message is automatically generated. > Normalize fuse-dfs handling of moving things to trash wrt the way hadoop dfs does it (only when non posix trash flag is enabled in compile) > ------------------------------------------------------------------------------------------------------------------------------------------- > > Key: HADOOP-3661 > URL: https://issues.apache.org/jira/browse/HADOOP-3661 > Project: Hadoop Core > Issue Type: Improvement > Components: contrib/fuse-dfs > Reporter: Pete Wyckoff > Assignee: Pete Wyckoff > Attachments: patch0.txt, patch0.txt, patch1.txt, patch2.txt, patch2.txt, patch2.txt, TEST-TestFuseDFS.txt > > > Currently fuse-dfs is very crude about moving things to Trash. It can only move them once since it doesn't use any numbering scheme to prevent overwrites. > Should look at the code that hadoop dfs uses to move things to the trash and have the same behavior, i think. > Leaving it as major because it's pretty annoying and you can't tell what's wrong when you get an EIO when deleting something. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.