hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom White" <tom.e.wh...@gmail.com>
Subject Re: Job API question - ArrayList instead of List?
Date Wed, 09 Jul 2008 19:11:49 GMT
I opened https://issues.apache.org/jira/browse/HADOOP-3219 for this
(I've just linked it to HADOOP-2268). I agree it would be nice to fix
this. Perhaps at the same time as HADOOP-1230, so we make incompatible
changes in one go?

Tom

On Wed, Jul 9, 2008 at 6:41 PM, Arun C Murthy <acm@yahoo-inc.com> wrote:
>
> On Jul 9, 2008, at 12:30 AM, Lukas Vlcek wrote:
>
>> Hi,
>>
>> The patch for this should be pretty easy, but does it mean that you
>> decided
>> not to change the API in order to keep it compatible?
>
> Unfortunately, yes - we had to.
>
>> I like Doug's idea about depreciation of original methods (those exposing
>> ArrayList into public API) and introducing equivalent methods with List
>> interface.
>>
>
> I think the deal fell through when we couldn't come up with agreeable
> alteratives for get/set methods... *smile*
>
> Arun
>
>> Regards,
>> Lukas
>>
>> On Wed, Jul 9, 2008 at 9:08 AM, Arun C Murthy <acm@yahoo-inc.com> wrote:
>>
>>>
>>> On Jul 8, 2008, at 3:11 PM, Lukas Vlcek wrote:
>>>
>>>  Hi,
>>>>
>>>> Why the Job API is using ArrayList instead of List?
>>>>
>>>> It is used in constructor:
>>>> public Job(JobConf jobConf, ArrayList<Job> dependingJobs)
>>>>
>>>> and one public method:
>>>> public ArrayList<Job> getDependingJobs()
>>>>
>>>> Is there any reason why it is referencing to implementation while it
>>>> could
>>>> be replaced by interface?
>>>>
>>>>
>>> Originally an oversight, we did file
>>> http://issues.apache.org/jira/browse/HADOOP-2268
>>> but didn't change it to keep it compatible...
>>>
>>> Arun
>>>
>>
>>
>>
>> --
>> http://blog.lukas-vlcek.com/
>
>

Mime
View raw message