hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-3791) Use generics in ReflectionUtils
Date Thu, 24 Jul 2008 06:35:31 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12616352#action_12616352
] 

Hadoop QA commented on HADOOP-3791:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12386721/hadoop-generics.patch
  against trunk revision 679202.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 6 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2932/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2932/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2932/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2932/console

This message is automatically generated.

> Use generics in ReflectionUtils
> -------------------------------
>
>                 Key: HADOOP-3791
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3791
>             Project: Hadoop Core
>          Issue Type: Task
>            Reporter: Chris Smith
>            Assignee: Chris Smith
>            Priority: Trivial
>         Attachments: hadoop-generics.patch, hadoop-generics.patch
>
>
> The attached patch makes ReflectionUtils.newInstance use generics appropriately. I've
also gone through and updated everywhere that calls ReflectionUtils.newInstance to remove
now-redundant casts, or to add further generics where appropriate. The overall result is about
17 fewer @SupressWarnings("unchecked") needed in the source tree. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message