hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Owen O'Malley (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-3761) FileSplit's default constructor should be made "public"
Date Tue, 15 Jul 2008 15:49:31 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613644#action_12613644
] 

Owen O'Malley commented on HADOOP-3761:
---------------------------------------

Making the constructor visible is reasonable, but it isn't necessary if you use ReflectionUtils.newInstance
to make instance. Even better is using the serialization framework so that it supports arbitrary
types (Thrift, Writable, ProtocolBuffers, etc)

> FileSplit's default constructor should be made "public"
> -------------------------------------------------------
>
>                 Key: HADOOP-3761
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3761
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: mapred
>            Reporter: Zheng Shao
>            Assignee: Zheng Shao
>            Priority: Trivial
>         Attachments: 3761-1.patch
>
>
> mapred.FileSplit's default constructor is currently "package" visible. We should make
it "public" so we can support a GenericSplit class outside mapred package, which could create
FileSplit instances using reflection and serialize/deserialize FileSplit through Writable
interface.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message