hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-3772) Proposed hadoop instrumentation API
Date Fri, 18 Jul 2008 21:07:31 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12614872#action_12614872
] 

Hadoop QA commented on HADOOP-3772:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12386422/instrumentation-2.patch
  against trunk revision 677872.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 1 new Findbugs warnings.

    -1 release audit.  The applied patch generated 213 release audit warnings (more than the
trunk's current 209 warnings).

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2904/testReport/
Release audit warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2904/artifact/trunk/current/releaseAuditDiffWarnings.txt
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2904/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2904/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2904/console

This message is automatically generated.

> Proposed hadoop instrumentation API
> -----------------------------------
>
>                 Key: HADOOP-3772
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3772
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: metrics
>            Reporter: Ari Rabkin
>            Assignee: Ari Rabkin
>         Attachments: instrumentation-2.patch, instrumentation.patch
>
>
> We want to evolve the Hadoop metrics subsystem into a more generic Instrumentation facility.
 The ultimate goal is to add structured logging to Hadoop, with causal tags, a la X-trace.
 The existing metrics framework is not quite suitable for our needs, since the implementation
and interface are tightly coupled. There's no way to use the metrics instrumentation points
for anything other than metricss, and there's no way for a metrics context to find out what
event just happened.  
> We want to tease apart the generic notion of hookable instrumentation points, from the
specifics of the information recording. The latter ought to  be pluggable at run-time.  

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message