hadoop-common-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HADOOP-3368) Can commons-logging.properties be pulled from hadoop-core?
Date Mon, 28 Jul 2008 16:17:31 GMT

    [ https://issues.apache.org/jira/browse/HADOOP-3368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12617456#action_12617456
] 

Hadoop QA commented on HADOOP-3368:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12387030/hadoop-3368.patch
  against trunk revision 679930.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no tests are needed for this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2959/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2959/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2959/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2959/console

This message is automatically generated.

> Can commons-logging.properties be pulled from hadoop-core?
> ----------------------------------------------------------
>
>                 Key: HADOOP-3368
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3368
>             Project: Hadoop Core
>          Issue Type: Improvement
>    Affects Versions: 0.19.0
>            Reporter: Steve Loughran
>         Attachments: hadoop-3368.patch
>
>
> In the root of hadoop-core.jar is a log4j.properties and a commons-logging.properties
> while this provides good standalone functionality to hadoop, it complicates anyone else
trying to control the logging, and use the libraries in-process.
> In particular, there is a commons-logging.properties file that selects Log4J as the back
end. This is not needed as
>  -log4j is automatically picked up if it is on the classpath 
>  -if it is not on the classpath, asking for it is generally considered bad form
> If you look at the commons-logging configuration details:
>  http://commons.apache.org/logging/guide.html#Configuration
> you will see that that such a properties file takes priority over any setting through
system properties, which makes it very hard to override the settings without adding multiple
commons-logging.properties files and playing with their priority settings 
> If you pull the commons-logging.properties file from hadoop-core log4j will still be
picked up by default, but it becomes easier for people to turn on different logging infrastructures
if they want to. It should have no visible impact on the end user experience (unlike pulling
log4j.properties)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message