Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 90276 invoked from network); 19 Jun 2008 20:32:08 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 19 Jun 2008 20:32:08 -0000 Received: (qmail 12248 invoked by uid 500); 19 Jun 2008 20:32:07 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 12218 invoked by uid 500); 19 Jun 2008 20:32:07 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 12207 invoked by uid 99); 19 Jun 2008 20:32:07 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Jun 2008 13:32:07 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 19 Jun 2008 20:31:26 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 174DE234C14D for ; Thu, 19 Jun 2008 13:31:45 -0700 (PDT) Message-ID: <813275035.1213907505094.JavaMail.jira@brutus> Date: Thu, 19 Jun 2008 13:31:45 -0700 (PDT) From: "Tsz Wo (Nicholas), SZE (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Commented: (HADOOP-3487) Balancer should not allocate a thread per block move In-Reply-To: <409028288.1212537045092.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-3487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12606547#action_12606547 ] Tsz Wo (Nicholas), SZE commented on HADOOP-3487: ------------------------------------------------ - It is better to use ExecutorService.submit(...) than Executor.execute(...). A Future object will be returned by submit(...) and it can be used for waiting the task termination. Then, dispatcherCount is not needed. - The InterruptedException in dispatchBlockMoves() should not be ignored. We need to shutdown the ExecutorService and terminate the program. > Balancer should not allocate a thread per block move > ---------------------------------------------------- > > Key: HADOOP-3487 > URL: https://issues.apache.org/jira/browse/HADOOP-3487 > Project: Hadoop Core > Issue Type: Bug > Components: dfs > Affects Versions: 0.17.0 > Reporter: Hairong Kuang > Assignee: Hairong Kuang > Priority: Blocker > Fix For: 0.18.0 > > Attachments: balancerThread.patch > > > It will be more efficient to use a thread pool to provision thread for each block move. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.