Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: core-dev@hadoop.apache.org
Message-ID: <35477394.1213648065107.JavaMail.jira@brutus>
Date: Mon, 16 Jun 2008 13:27:45 -0700 (PDT)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: core-dev@hadoop.apache.org
Subject: [jira] Commented: (HADOOP-3556) Substitute the synchronized code in
 MD5Hash to avoid lock contention. Use ThreadLocal instead.
In-Reply-To: <1237046750.1213371644920.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/HADOOP-3556?page=3Dcom.atlassia=
n.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D126=
05401#action_12605401 ]=20

Hadoop QA commented on HADOOP-3556:
-----------------------------------

+1 overall.  Here are the results of testing the latest attachment=20
  http://issues.apache.org/jira/secure/attachment/12384043/3556.patch
  against trunk revision 667706.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified test=
s.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of java=
c compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number=
 of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2665/t=
estReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2=
665/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/=
2665/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2665=
/console

This message is automatically generated.

> Substitute the synchronized code in MD5Hash to avoid lock contention. Use=
 ThreadLocal instead.
> -------------------------------------------------------------------------=
---------------------
>
>                 Key: HADOOP-3556
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3556
>             Project: Hadoop Core
>          Issue Type: Improvement
>            Reporter: Iv=C3=A1n de Prado
>            Assignee: Iv=C3=A1n de Prado
>         Attachments: 3556.patch, MD5Hash-ThreadLocal.patch
>
>
> Currently the MD5Hash class uses a singleton instance of the MessageDiges=
ter. The access to this instance is synchronized, so MD5Hash has performanc=
e problems when used from several Threads. I propose to substitute the sing=
leton instance by a TheadLocal instances cache. I will provide a patch.

--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.