Return-Path: Delivered-To: apmail-hadoop-core-dev-archive@www.apache.org Received: (qmail 60606 invoked from network); 3 Jun 2008 17:07:08 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 3 Jun 2008 17:07:08 -0000 Received: (qmail 99561 invoked by uid 500); 3 Jun 2008 17:07:08 -0000 Delivered-To: apmail-hadoop-core-dev-archive@hadoop.apache.org Received: (qmail 99522 invoked by uid 500); 3 Jun 2008 17:07:08 -0000 Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: core-dev@hadoop.apache.org Delivered-To: mailing list core-dev@hadoop.apache.org Received: (qmail 99500 invoked by uid 99); 3 Jun 2008 17:07:08 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jun 2008 10:07:08 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Jun 2008 17:06:28 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 17360234C12F for ; Tue, 3 Jun 2008 10:06:45 -0700 (PDT) Message-ID: <173873015.1212512805093.JavaMail.jira@brutus> Date: Tue, 3 Jun 2008 10:06:45 -0700 (PDT) From: "Mahadev konar (JIRA)" To: core-dev@hadoop.apache.org Subject: [jira] Commented: (HADOOP-3427) In ReduceTask::fetchOutputs, wait for result can be improved slightly In-Reply-To: <776736020.1211374795666.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HADOOP-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601995#action_12601995 ] Mahadev konar commented on HADOOP-3427: --------------------------------------- +1 the patch looks good, though the fetchoutputs() needs refactoring urgently. > In ReduceTask::fetchOutputs, wait for result can be improved slightly > --------------------------------------------------------------------- > > Key: HADOOP-3427 > URL: https://issues.apache.org/jira/browse/HADOOP-3427 > Project: Hadoop Core > Issue Type: Bug > Components: mapred > Reporter: Devaraj Das > Assignee: Devaraj Das > Fix For: 0.18.0 > > Attachments: 3427.patch, 3427.patch, 3427.patch > > > The getCopyResult call in ReduceTask::fetchOutputs waits for 2 seconds if the results list is empty. This can be improved to wait only when sufficient number of fetches (above a certain threshold) have been scheduled. The threshold should ensure that all the fetcher threads would be busy enough, and in this case, the call to getCopyResult would return only when a fetcher thread wakes it up. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.