Mailing-List: contact core-dev-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: core-dev@hadoop.apache.org
Message-ID: <1394834049.1214385885300.JavaMail.jira@brutus>
Date: Wed, 25 Jun 2008 02:24:45 -0700 (PDT)
From: "Tom White (JIRA)" <jira@apache.org>
To: core-dev@hadoop.apache.org
Subject: [jira] Created: (HADOOP-3640) NativeS3FsInputStream read() method
 for reading a single byte is incorrect
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit

NativeS3FsInputStream read() method for reading a single byte is incorrect
--------------------------------------------------------------------------

                 Key: HADOOP-3640
                 URL: https://issues.apache.org/jira/browse/HADOOP-3640
             Project: Hadoop Core
          Issue Type: Bug
    Affects Versions: 0.18.0
            Reporter: Tom White
            Assignee: Tom White


>From Albert Chern:

I think there may be a bug in the read() method of NativeS3InputStream, which looks like this:

{code}
public synchronized int read() throws IOException {
    int result = in.read();
    if (result > 0) {
        pos += result;
    }
    return result;
}
{code}

The return value of InputStream.read() should be the next byte in the range 0 to 255, or -1 if there are no more bytes.  So shouldn't this method look something like this?

{code}
public synchronized int read() throws IOException {
    int result = in.read();
    if (result > -1) {
        pos ++;
    }
    return result;
}
{code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.